Re: [PATCH v3 5/7] tee: Support shm registration without dma-buf backing
From: Jens Wiklander
Date: Thu Jun 10 2021 - 03:34:40 EST
On Wed, Jun 09, 2021 at 08:51:04AM -0500, Tyler Hicks wrote:
> > > I've just posted "[PATCH 0/7] tee: shared memory updates",
> > > https://lore.kernel.org/lkml/20210609102324.2222332-1-jens.wiklander@xxxxxxxxxx/
> > >
> > > Where tee_shm_alloc() is replaced by among other functions
> > > tee_shm_alloc_kernel_buf(). tee_shm_alloc_kernel_buf() takes care of the
> > > problem with TEE_SHM_DMA_BUF.
> > Thanks! At first glance, that series would take care of the last three
> > patches in my kexec/kdump series.
> Correction: Your series would not completely take care of the last three
> patches in my kexec/kdump series because your series doesn't implement
> the .shutdown() hook for tee_bnxt_fw.
> Does it make sense to take my series first and then rebase your series
> on top of it? That would allow my fixes to flow back to stable, then
> your changes would greatly clean up the implementation in future
Yes, we could try that. I'd like to see tee_shm_alloc_kernel_buf() being
used instead of tee_shm_alloc() in ftpm_tee_probe() and
tee_bnxt_fw_probe(). So it would be great if you could include "tee: add
tee_shm_alloc_kernel_buf()" in your patch set.
My patch set would then shrink a bit. By the way, thanks for reviewing