Re: [PATCH v7 3/8] PCI: Remove reset_fn field from pci_dev

From: Shanker R Donthineni
Date: Thu Jun 10 2021 - 16:16:24 EST




On 6/8/21 12:48 AM, Amey Narkhede wrote:
> reset_fn field is used to indicate whether the device supports any reset
> mechanism or not. Remove the use of reset_fn in favor of new reset_methods
> array which can be used to keep track of all supported reset mechanisms of
> a device and their ordering.
>
> The octeon driver is incorrectly using
> reset_fn field to detect if the device supports FLR or not. Use
> pcie_reset_flr() to probe whether it supports FLR or not.
>
> Reviewed-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> Reviewed-by: Raphael Norwitz <raphael.norwitz@xxxxxxxxxxx>
> Co-developed-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> Signed-off-by: Amey Narkhede <ameynarkhede03@xxxxxxxxx>

Tested-by: Shanker Donthineni <sdonthineni@xxxxxxxxxx>