Re: [RFC PATCH] mm/oom_kill: allow oom kill allocating task for non-global case

From: Michal Hocko
Date: Fri Jun 11 2021 - 02:55:52 EST


On Thu 10-06-21 23:06:47, Tetsuo Handa wrote:
> On 2021/06/10 22:36, Aaron Tomlin wrote:
> > On Thu 2021-06-10 14:43 +0200, Michal Hocko wrote:
> >> Well, I am not sure this is a good thing in general. We do not want to
> >> hide tasks. We already do display oom_score_adj_min even though they are
> >> not eligible and that can serve a good purpose from my experience. It
> >> gives us some picture at least. Maybe a flag to mark all uneligible
> >> tasks would be something useful but I wouldn't drop them from the list.
> >
> > Fair enough.
>
> Yes, marking ineligible (i.e. oom_badness() returning LONG_MIN) tasks would be useful.
>
> By the way, was the task namely "node" (i.e. PID 1703345) multithreaded program?
> Your kernel might want commit 7775face207922ea ("memcg: killed threads should not invoke memcg OOM killer").

Yes, this would help for multithreaded race situation indeed. Thanks!

--
Michal Hocko
SUSE Labs