Re: [RFC PATCH 64/67] KVM: TDX: Add "basic" support for building and running Trust Domains

[Isaku Yamahata]

On Thu, Jun 10, 2021 at 07:33:29PM -0700,
Erdem Aktas <erdemaktas@xxxxxxxxxx> wrote:

> some more feedback on KVM_TDX_INIT_MEM_REGION:
> 
> KVM_TDX_INIT_MEM_REGION requires a source and destination address
> which is a little counterintuitive (debatable). I think this requires
> better documentation to explain the usage better. I was wrongly
> expecting to provide the guest memory which has the code as a pointer
> and expecting it to be in-place measured and encrypted.
> 
> KVM_TDX_INIT_MEM_REGION crashes the host when:
> * Target gpa is not valid or not backed by a page
> * When source and destination overlap


Thanks for feedback.
On next respin, I'm going to document new API more.

-- 
Isaku Yamahata <isaku.yamahata@xxxxxxxxx>