Re: [PATCH v11 01/33] mm: Convert get_page_unless_zero() to return bool

From: Christoph Hellwig
Date: Tue Jun 15 2021 - 02:25:33 EST


On Mon, Jun 14, 2021 at 09:14:03PM +0100, Matthew Wilcox (Oracle) wrote:
> atomic_add_unless() returns bool, so remove the widening casts to int
> in page_ref_add_unless() and get_page_unless_zero(). This causes gcc
> to produce slightly larger code in isolate_migratepages_block(), but
> it's not clear that it's worse code. Net +19 bytes of text.

Strange. Anyway, this looks like the right type, so:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>