Re: [PATCH v7 1/6] kernfs: move revalidate to be near lookup

From: Greg Kroah-Hartman
Date: Tue Jun 15 2021 - 11:06:52 EST


On Tue, Jun 15, 2021 at 06:25:53PM +0800, Ian Kent wrote:
> While the dentry operation kernfs_dop_revalidate() is grouped with
> dentry type functions it also has a strong affinity to the inode
> operation ->lookup().
>
> It makes sense to locate this function near to kernfs_iop_lookup()
> because we will be adding VFS negative dentry caching to reduce path
> lookup overhead for non-existent paths.
>
> There's no functional change from this patch.
>
> Signed-off-by: Ian Kent <raven@xxxxxxxxxx>
> Reviewed-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>
> ---
> fs/kernfs/dir.c | 86 ++++++++++++++++++++++++++++---------------------------
> 1 file changed, 43 insertions(+), 43 deletions(-)

As everyone has agreed this patch does nothing wrong, I've applied this
one for now while everyone reviews the other ones :)

thanks,

greg k-h