Re: [PATCH v4 02/24] x86/resctrl: Split struct rdt_domain

[Reinette Chatre]

Hi James,

On 6/14/2021 1:09 PM, James Morse wrote:
> resctrl is the defacto Linux ABI for SoC resource partitioning features.
>
> To support it on another architecture, it needs to be abstracted from
> the features provided by Intel RDT and AMD PQoS, and moved to /fs/.
> struct rdt_resource contains a mix of architecture private details
> and properties of the filesystem interface user-space users.

rdt_resource -> rdt_domain ?
user-space users -> user-space uses ?

> Continue by splitting struct rdt_domain, into an architecture private
> 'hw' struct, which contains the common resctrl structure that would be
> used by any architecture. The hardware values in ctrl_val and mbps_val
> need to be accessed via helpers to allow another architecture to convert
> these into a different format if necessary. After this split, filesystem
> code paths touching a 'hw' struct indicates where an abstraction
> is needed.
>
> Splitting this structure only moves types around, and should not lead
> to any change in behaviour.
>
> Reviewed-by: Jamie Iles <jamie@xxxxxxxxxxxx>
> Signed-off-by: James Morse <james.morse@xxxxxxx>

Reinette