[PATCH v2 1/1] platform/chrome: cros_ec_typec: Put fwnode in error case during ->probe()

From: Andy Shevchenko
Date: Tue Jun 15 2021 - 17:51:17 EST


device_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.

Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
Signed-off-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Reviewed-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
---
v2: added comment (Prashant), added Rb tag (Prashant)
drivers/platform/chrome/cros_ec_typec.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 27c068c4c38d..99fdc1156392 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -375,6 +375,8 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
return 0;

unregister_ports:
+ /* Drop the referece that bumped by device_for_each_child_node() */
+ fwnode_handle_put(fwnode);
cros_unregister_ports(typec);
return ret;
}
--
2.32.0