Re: [PATCH][next] ALSA: bebob: Fix bit flag quirk constants

From: Takashi Iwai
Date: Wed Jun 16 2021 - 02:53:59 EST


On Tue, 15 Jun 2021 16:20:48 +0200,
Colin King wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The quirking bit-flags are currently set as contiguous integer enum values
> and so currently SND_BEBOB_QUIRK_INITIAL_DISCONTINUOUS_DBC is zero and so
> he quirking never getting set or tested correctly for this quirk. Fix this
> by setting the quirking constants as shifted bit values.
>
> Addresses-Coverity: ("Bitwise-and with zero")
> Fixes: 93cd12d6e88a ("ALSA: bebob: code refactoring for model-dependent quirks")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks, applied.


Takashi