Re: [PATCH v2 1/1] mcb: Use DEFINE_RES_MEM() to simplify code
From: Greg Kroah-Hartman
Date: Wed Jun 16 2021 - 03:17:46 EST
On Wed, Jun 16, 2021 at 02:57:14PM +0800, Leizhen (ThunderTown) wrote:
> On 2021/6/16 14:41, Greg Kroah-Hartman wrote:
> > On Wed, Jun 16, 2021 at 09:55:09AM +0800, Zhen Lei wrote:
> >> Use DEFINE_RES_MEM() to save a couple of lines of code, which makes the
> >> code a bit shorter and easier to read. The start address does not need to
> >> appear twice.
> >> By the way, the value of '.end' should be "start + size - 1". So the
> >> previous writing should have omitted subtracted 1.
> > Does that mean the current code is wrong and this is a bugfix? If so,
> > what commit id does this fix?
> OK, I'll add Fixes.
> However, some people think that only functional fixes need to add "Fixes".
If this is not a "fix" then that is fine, I can take it as-is, it just
was not obvious.