Re: [PATCH v7 1/5] string_helpers: Escape double quotes in escape_special

From: Andy Shevchenko
Date: Wed Jun 16 2021 - 04:08:36 EST


On Tue, Jun 15, 2021 at 07:05:25PM -0700, Randy Dunlap wrote:
> On 6/15/21 5:00 PM, Chris Down wrote:
> > Andy Shevchenko writes:
> >>> I've checked uses of ESCAPE_SPECIAL and %pE across the codebase, and I'm
> >>
> >> checked the uses
> >
> > Hmm, what's wrong with using the zero article for "checked uses"? I mean, I don't have any strong resistance, but I don't see anything wrong with it either, and it matches how I'd naturally speak.
> >
> > Agreed on the others, though, hopefully they can be massaged in :-)
>
> Ack, I don't see anything wrong with it either.

I guess you know better than me :-)

I'm just a mere non-native speaker here to whom it's stylistically harder to
parse without the article.


--
With Best Regards,
Andy Shevchenko