Re: [PATCH v11 01/33] mm: Convert get_page_unless_zero() to return bool

From: David Howells
Date: Wed Jun 16 2021 - 05:19:35 EST


Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:

> atomic_add_unless() returns bool, so remove the widening casts to int
> in page_ref_add_unless() and get_page_unless_zero(). This causes gcc
> to produce slightly larger code in isolate_migratepages_block(), but
> it's not clear that it's worse code. Net +19 bytes of text.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Reviewed-by: David Howells <dhowells@xxxxxxxxxx>