Re: [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling

From: Nick Kossifidis
Date: Wed Jun 16 2021 - 06:43:44 EST


Στις 2021-06-16 10:56, Geert Uytterhoeven έγραψε:

I can't comment on the duplication on arm64, but to me, /chosen
sounds like the natural place for both "linux,elfcorehdr" and
"linux,usable-memory-range". First rule of DT is "DT describes
hardware, not software policy", with /chosen describing some software
configuration.


We already have "linux,usable-memory" on /memory node:
https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L1011
and it makes perfect sense to be there since it overrides /memory's reg property.

Why define another binding for the same thing on /chosen ?


OK, thanks!
But do you need the entry on the reservation map?


I'll add the entry from kexec-tools, so that the kernel will reserve the region as part of:
https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L605