Re: [PATCH v11 24/33] mm/swap: Add folio_rotate_reclaimable()

From: Matthew Wilcox
Date: Wed Jun 16 2021 - 07:47:18 EST


On Wed, Jun 16, 2021 at 11:27:02AM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx> wrote:
>
> > + !folio_unevictable(folio) && folio_lru(folio)) {
>
> Hmmm... Would folio_lru() be better named folio_on_lru()? folio_lru() sounds
> like it returns the folio's LRU.

That's folio_lru_list(). It's just that we have a bad habit of saying
"the lru" instead of "the lru list".