Re: [PATCH v8 RESEND] staging: unisys: visorhba: Convert module from IDR to XArray

From: Fabio M. De Francesco
Date: Wed Jun 16 2021 - 12:56:50 EST


On Tuesday, June 15, 2021 1:50:15 PM CEST Greg Kroah-Hartman wrote:
> On Fri, May 14, 2021 at 10:11:11AM +0200, Fabio M. De Francesco wrote:
> > Converted visorhba from IDR to XArray. The abstract data type XArray is
> > more memory-efficient, parallelizable, and cache friendly. It takes
> > advantage of RCU to perform lookups without locking. Furthermore, IDR is
> > deprecated because XArray has a better (cleaner and more consistent)
> > API.
> >
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
>
> Given a lack of response from the unisys maintainer, I'll go apply this
> now and see what breaks :)
>
Hi Greg,

I'm really grateful to you for having applied that patch notwithstanding the
lack of response from Unisys. Understanding IDR, XArray, and the flow of the
code, has been a hard task for a newcomer having only a month of experience to
kernel development.

Thanks very much,

Fabio
>
> thanks,
>
> greg k-h