[PATCH][next] scsi: elx: libefc: Fix less than zero comparison of a unsigned int

From: Colin King
Date: Wed Jun 16 2021 - 13:04:33 EST


From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

The comparison of the u32 variable rc to less than zero always
false because it is unsigned. Fix this by making it an int.

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 202bfdffae27 ("scsi: elx: libefc: FC node ELS and state handling")
Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
---
drivers/scsi/elx/libefc/efc_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/elx/libefc/efc_device.c b/drivers/scsi/elx/libefc/efc_device.c
index 31a688bce6e9..725ca2a23fb2 100644
--- a/drivers/scsi/elx/libefc/efc_device.c
+++ b/drivers/scsi/elx/libefc/efc_device.c
@@ -15,7 +15,7 @@
void
efc_d_send_prli_rsp(struct efc_node *node, u16 ox_id)
{
- u32 rc = EFC_SCSI_CALL_COMPLETE;
+ int rc = EFC_SCSI_CALL_COMPLETE;
struct efc *efc = node->efc;

node->ls_acc_oxid = ox_id;
--
2.31.1