Re: [PATCH 09/16] char: agp: backend: Demote some non-conformant kernel-doc headers

From: Lee Jones
Date: Thu Jun 17 2021 - 05:52:34 EST


On Thu, 20 May 2021, Lee Jones wrote:

> Fixes the following W=1 kernel build warning(s):
>
> drivers/char/agp/backend.c:68: warning: Function parameter or member 'pdev' not described in 'agp_backend_acquire'
> drivers/char/agp/backend.c:93: warning: Function parameter or member 'bridge' not described in 'agp_backend_release'
>
> Cc: David Airlie <airlied@xxxxxxxx>

David, are you planning on taking these 'agp' patches please?

> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> ---
> drivers/char/agp/backend.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/agp/backend.c b/drivers/char/agp/backend.c
> index 004a3ce8ba72d..c901c719fba89 100644
> --- a/drivers/char/agp/backend.c
> +++ b/drivers/char/agp/backend.c
> @@ -60,7 +60,7 @@ EXPORT_SYMBOL(agp_bridge);
> EXPORT_SYMBOL(agp_bridges);
> EXPORT_SYMBOL(agp_find_bridge);
>
> -/**
> +/*
> * agp_backend_acquire - attempt to acquire an agp backend.
> *
> */
> @@ -81,7 +81,7 @@ struct agp_bridge_data *agp_backend_acquire(struct pci_dev *pdev)
> EXPORT_SYMBOL(agp_backend_acquire);
>
>
> -/**
> +/*
> * agp_backend_release - release the lock on the agp backend.
> *
> * The caller must insure that the graphics aperture translation table

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog