RE: [PATCH V2 net-next 0/2] net: fec: fix TX bandwidth fluctuations

[Joakim Zhang]

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: 2021年6月16日 21:06
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> Cc: David Miller <davem@xxxxxxxxxxxxx>; kuba@xxxxxxxxxx;
> frieder.schrempf@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V2 net-next 0/2] net: fec: fix TX bandwidth fluctuations
> 
> > I try below build options, also can't reproduce this issue, so really don't know
> how to fix it.
> >
> > make ARCH=arm64 distclean
> > make ARCH=arm64 allmodconfig
> > make -j8 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- W=1 / make -j8
> ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- W=2 / make -j8
> ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- W=3
> >
> > I saw many unrelated warnings...
> 
> Then it could be sparse. Install sparse and use C=1.

After applying the patch #2, I tried to use C=1 yesterday, I double check it today, still no warnings. Anything I missing?

$ make -j8 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- W=1,C=1
  CALL    scripts/atomic/check-atomics.sh
  CALL    scripts/checksyscalls.sh
  CHK     include/generated/compile.h
  CHK     kernel/kheaders_data.tar.xz
  CC [M]  drivers/net/ethernet/freescale/fec_main.o
  LD [M]  drivers/net/ethernet/freescale/fec.o
  MODPOST modules-only.symvers
  GEN     Module.symvers
  CC [M]  drivers/net/ethernet/freescale/fec.mod.o
  LD [M]  drivers/net/ethernet/freescale/fec.ko

Best Regards,
Joakim Zhang
>      Andrew