Re: [PATCH 4/8] membarrier: Make the post-switch-mm barrier explicit
From: Paul E. McKenney
Date: Thu Jun 17 2021 - 11:02:18 EST
On Wed, Jun 16, 2021 at 10:32:15PM -0700, Andy Lutomirski wrote:
> On Wed, Jun 16, 2021, at 7:57 PM, Andy Lutomirski wrote:
> > On Wed, Jun 16, 2021, at 6:37 PM, Nicholas Piggin wrote:
> > > Excerpts from Andy Lutomirski's message of June 17, 2021 4:41 am:
> > > > On 6/16/21 12:35 AM, Peter Zijlstra wrote:
> > > >> On Wed, Jun 16, 2021 at 02:19:49PM +1000, Nicholas Piggin wrote:
> > > >>> Excerpts from Andy Lutomirski's message of June 16, 2021 1:21 pm:
> > > >>>> membarrier() needs a barrier after any CPU changes mm. There is currently
> > > >>>> a comment explaining why this barrier probably exists in all cases. This
> > > >>>> is very fragile -- any change to the relevant parts of the scheduler
> > > >>>> might get rid of these barriers, and it's not really clear to me that
> > > >>>> the barrier actually exists in all necessary cases.
> > > >>>
> > > >>> The comments and barriers in the mmdrop() hunks? I don't see what is
> > > >>> fragile or maybe-buggy about this. The barrier definitely exists.
> > > >>>
> > > >>> And any change can change anything, that doesn't make it fragile. My
> > > >>> lazy tlb refcounting change avoids the mmdrop in some cases, but it
> > > >>> replaces it with smp_mb for example.
> > > >>
> > > >> I'm with Nick again, on this. You're adding extra barriers for no
> > > >> discernible reason, that's not generally encouraged, seeing how extra
> > > >> barriers is extra slow.
> > > >>
> > > >> Both mmdrop() itself, as well as the callsite have comments saying how
> > > >> membarrier relies on the implied barrier, what's fragile about that?
> > > >>
> > > >
> > > > My real motivation is that mmgrab() and mmdrop() don't actually need to
> > > > be full barriers. The current implementation has them being full
> > > > barriers, and the current implementation is quite slow. So let's try
> > > > that commit message again:
> > > >
> > > > membarrier() needs a barrier after any CPU changes mm. There is currently
> > > > a comment explaining why this barrier probably exists in all cases. The
> > > > logic is based on ensuring that the barrier exists on every control flow
> > > > path through the scheduler. It also relies on mmgrab() and mmdrop() being
> > > > full barriers.
> > > >
> > > > mmgrab() and mmdrop() would be better if they were not full barriers. As a
> > > > trivial optimization, mmgrab() could use a relaxed atomic and mmdrop()
> > > > could use a release on architectures that have these operations.
> > >
> > > I'm not against the idea, I've looked at something similar before (not
> > > for mmdrop but a different primitive). Also my lazy tlb shootdown series
> > > could possibly take advantage of this, I might cherry pick it and test
> > > performance :)
> > >
> > > I don't think it belongs in this series though. Should go together with
> > > something that takes advantage of it.
> > I’m going to see if I can get hazard pointers into shape quickly.
One textbook C implementation is in perfbook CodeSamples/defer/hazptr.[hc]
A production-tested C++ implementation is in the folly library:
However, the hazard-pointers get-a-reference operation requires a full
barrier. There are ways to optimize this away in some special cases,
one of which is used in the folly-library hash-map code.
> Here it is. Not even boot tested!
> Nick, I think you can accomplish much the same thing as your patch by:
> #define for_each_possible_lazymm_cpu while (false)
> although a more clever definition might be even more performant.
> I would appreciate everyone's thoughts as to whether this scheme is sane.
> Paul, I'm adding you for two reasons. First, you seem to enjoy bizarre locking schemes. Secondly, because maybe RCU could actually work here. The basic idea is that we want to keep an mm_struct from being freed at an inopportune time. The problem with naively using RCU is that each CPU can use one single mm_struct while in an idle extended quiescent state (but not a user extended quiescent state). So rcu_read_lock() is right out. If RCU could understand this concept, then maybe it could help us, but this seems a bit out of scope for RCU.
OK, I should look at your patch, but that will be after morning meetings.
On RCU and idle, much of the idle code now allows rcu_read_lock() to be
directly, thanks to Peter's recent work. Any sort of interrupt or NMI
from idle can also use rcu_read_lock(), including the IPIs that are now
done directly from idle. RCU_NONIDLE() makes RCU pay attention to the
code supplied as its sole argument.
Or is your patch really having the CPU expect a mm_struct to stick around
across the full idle sojourn, and without the assistance of mmgrab()
Anyway, off to meetings... Hope this helps in the meantime.