Re: [PATCH -next] crypto: sl3516 - Fix build warning without CONFIG_PM

[YueHaibing]

On 2021/6/17 21:00, LABBE Corentin wrote:
> Le Thu, Jun 17, 2021 at 11:51:29AM +0800, YueHaibing a écrit :
>> drivers/crypto/gemini/sl3516-ce-core.c:345:12:
>>  warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function]
>>  static int sl3516_ce_pm_resume(struct device *dev)
>>             ^~~~~~~~~~~~~~~~~~~
>>
>> Use #ifdef macro to guard this.
>>
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> ---
>>  drivers/crypto/gemini/sl3516-ce-core.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
> 
> Hello
> 
> Thanks for the report, but I am sorry and need to NAK this patch.
> 
> The driver needs PM, without it, clock and resets are never set.
> The correct fix is to add "depends on PM".

Ok, v2 on the way, thanks.

> 
> Regards
> .
>