Re: [PATCH] ASoC: fsl_xcvr: disable all interrupts when suspend happens

From: Mark Brown
Date: Fri Jun 18 2021 - 07:33:46 EST


On Fri, Jun 18, 2021 at 07:30:25PM +0800, Shengjiu Wang wrote:
> On Fri, Jun 18, 2021 at 7:21 PM Fabio Estevam <festevam@xxxxxxxxx> wrote:

> > The operations in _suspend() are usually balanced with the ones in _resume().

> > Shouldn't you enable the interrupts in resume() then?

> No, as you said below, the interrupts are enabled in fsl_xcvr_prepare().
> so this change should not block anything.

Might be worth a comment explaining why there's the asymmetry.

Attachment: signature.asc
Description: PGP signature