Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl

From: Catalin Marinas
Date: Fri Jun 18 2021 - 10:52:50 EST


On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote:
> +When this capability is enabled all memory in (non-device) memslots must not
> +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result
> +in an -EINVAL return.

"must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as
that's a kernel internal and not something the VMM needs to be aware of.
Just say something like "memslots must be mapped as shareable
(MAP_SHARED)".

Otherwise:

Reviewed-by: Catalin Marinas <catalin.marinas@xxxxxxx>