Re: [PATCH] afs: Re-enable freezing once a page fault is interrupted
From: Linus Torvalds
Date: Fri Jun 18 2021 - 16:53:03 EST
On Wed, Jun 16, 2021 at 2:22 PM David Howells <dhowells@xxxxxxxxxx> wrote:
> If a task is killed during a page fault, it does not currently call
> sb_end_pagefault(), which means that the filesystem cannot be frozen
> at any time thereafter. This may be reported by lockdep like this:
I've applied this patch.
Everything in my screams "the sb_start/end_pagefault() code is
completely broken", but in the meantime this patch fixes the immediate
I suspect that the whole sb_start/end_pagefault thing should just go
away entirely, and the freezer should be re-examined. Alternatively,
it should just be done by generic code, not by the filesystem.
But it is what it is.