Re: [PATCH] staging: rtl8188eu: remove useless comment

From: Martin Kaiser
Date: Sun Jun 20 2021 - 09:32:12 EST


Thus wrote Michael Straube (straube.linux@xxxxxxxxx):

> Remove block comment about function HwSuspendModeEnable92Cu.
> The comment contains no useful information and there is even
> no HwSuspendModeEnable92Cu function in the driver code.
> 'git grep -n HwSuspendModeEnable92Cu drivers/staging/rtl8188eu'
> returns nothing.

> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
> ---
> drivers/staging/rtl8188eu/hal/usb_halinit.c | 16 ----------------
> 1 file changed, 16 deletions(-)

> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index dcdf868b394d..6c88675ae251 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -601,22 +601,6 @@ static void _InitAntenna_Selection(struct adapter *Adapter)
> haldata->CurAntenna = Antenna_B;
> }

> -/*-----------------------------------------------------------------------------
> - * Function: HwSuspendModeEnable92Cu()
> - *
> - * Overview: HW suspend mode switch.
> - *
> - * Input: NONE
> - *
> - * Output: NONE
> - *
> - * Return: NONE
> - *
> - * Revised History:
> - * When Who Remark
> - * 08/23/2010 MHC HW suspend mode switch test..
> - *---------------------------------------------------------------------------
> - */
> enum rt_rf_power_state RfOnOffDetect(struct adapter *adapt)
> {
> u8 val8;
> --
> 2.32.0

You're right. The function for this comment is already gone.

Reviewed-by: Martin Kaiser <martin@xxxxxxxxx>