Re: [PATCH] block: mtip32xx: set the pointer of queue to null after cleaning

From: Zheyu Ma
Date: Mon Jun 21 2021 - 03:50:43 EST


On Mon, Jun 21, 2021 at 2:16 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
>
> On Sun, Jun 20, 2021 at 12:19:17PM +0000, Zheyu Ma wrote:
> > When 'mtip_block_initialize' fails at 'mtip_hw_get_identify', a series
> > of cleanup operations will be performed. But when the execution reaches
> > 'put_disk', it will cause refcount underflow. The reason for this error
> > is that after cleaning 'dd->queue', 'dd->disk->queue' was not set to
> > null at the same time, which caused repeated cleanup work.
> >
> > Fix this by set 'dd->disk->queue' to null after cleaning
>
> This should all be fixed by the switch to blk_cleanup_disk and the
> preparation for it in linux-next.

Thanks for your reply, I have switched to the linux-next branch.

Best regards,
Zheyu Ma