Re: [RFC PATCH v3 01/12] firmware: arm_scmi, smccc, mailbox: Make shmem based transports optional

From: Sudeep Holla
Date: Mon Jun 21 2021 - 04:54:56 EST


On Sun, Jun 20, 2021 at 11:09:21PM -0500, Jassi Brar wrote:
> On Mon, May 10, 2021 at 7:22 PM Peter Hilber
> <peter.hilber@xxxxxxxxxxxxxxx> wrote:
>
> .....
>
> > --- a/drivers/mailbox/Kconfig
> > +++ b/drivers/mailbox/Kconfig
> > @@ -1,6 +1,7 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > menuconfig MAILBOX
> > bool "Mailbox Hardware Support"
> > + select ARM_SCMI_HAVE_SHMEM
> > help
> > Mailbox is a framework to control hardware communication between
> > on-chip processors through queued messages and interrupt driven
> >
> Isn't this too generic?
> Not all platforms, with a mailbox controller, use SCMI as the protocol.
>

Yikes! I agree Jassi, this looks super hack.

--
Regards,
Sudeep