Re: [PATCH] mips/kvm: Use BUG_ON instead of if condition followed by BUG

From: Thomas Bogendoerfer
Date: Mon Jun 21 2021 - 05:54:24 EST


On Fri, Apr 23, 2021 at 01:35:09AM -0700, zhouchuangao wrote:
> BUG_ON uses unlikely in if(), it can be optimized at compile time.
>
> Usually, the condition in if() is not satisfied. In my opinion,
> this can improve the efficiency of the multi-stage pipeline.
>
> Signed-off-by: zhouchuangao <zhouchuangao@xxxxxxxx>
> ---
> arch/mips/kvm/tlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]