Re: [PATCH v3 2/3] kasan: integrate the common part of two KASAN tag-based modes

From: Alexander Potapenko
Date: Tue Jun 22 2021 - 05:28:32 EST

> diff --git a/mm/kasan/report_tags.h b/mm/kasan/report_tags.h
> new file mode 100644
> index 000000000000..1cb872177904
> --- /dev/null
> +++ b/mm/kasan/report_tags.h
Why don't you make it a C file instead?

> +const char *kasan_get_bug_type(struct kasan_access_info *info)
If this function has to be in the header, it should be declared as
static inline.
But I don't think it has to be there in the first place.