---- end ----Hi John,
Parse and process metrics: FAILED!
Note that the "FAILED" messages from the test code come from pr_debug().
In a way, I feel that pr_debug()/err from the test is more important
than pr_debug() from the core code (when running a test).
Any opinion on this or how to improve (if anyone agrees with me)? Or am
I missing something? Or is it not so important?
I think the issue is that in the parsing you don't know it's broken
until something goes wrong. Putting everything on pr_err would cause
spam in the not broken case.
Improving the parsing error handling is a
big task with lex and yacc to some extent getting in the way. Perhaps
a middle way is to have a parameter to the parser that logs more, and
recursively call this in the parser when parsing fails. I guess there
is also a danger of a performance hit.