Re: [PATCH 1/2] io_uring: Fix race condition when sqp thread goes to sleep

From: Olivier Langlois
Date: Tue Jun 22 2021 - 15:08:02 EST


On Tue, 2021-06-22 at 19:55 +0100, Pavel Begunkov wrote:
> On 6/22/21 7:53 PM, Olivier Langlois wrote:
> > On Tue, 2021-06-22 at 11:45 -0700, Olivier Langlois wrote:
> > > If an asynchronous completion happens before the task is
> > > preparing
> > > itself to wait and set its state to TASK_INTERRUPTABLE, the
> > > completion
> > > will not wake up the sqp thread.
> > >
> > I have just noticed that I made a typo in the description. I will
> > send
> > a v2 of that patch.
> >
> > Sorry about that. I was too excited to share my discovery...
>
> git format-patch --cover-letter --thread=shallow ...
>
> would be even better, but the fix looks right
>
You are too good... I thought that I could get away from hacking
manually the patch file for such a minor change...

It seems that I got caught...

Let me know if you need me to redo it the right way...