Re: [PATCH v2 10/46] mm/rmap: Add folio_mkclean()

From: Christoph Hellwig
Date: Wed Jun 23 2021 - 04:09:31 EST


On Tue, Jun 22, 2021 at 01:15:15PM +0100, Matthew Wilcox (Oracle) wrote:
> Transform page_mkclean() into folio_mkclean() and add a page_mkclean()
> wrapper around folio_mkclean().
>
> folio_mkclean is 15 bytes smaller than page_mkclean, but the kernel
> is enlarged by 33 bytes due to inlining page_folio() into each caller.
> This will go away once the callers are converted to use folio_mkclean().
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>