Re: [PATCH v2 31/46] mm/writeback: Add folio_clear_dirty_for_io()

From: Christoph Hellwig
Date: Wed Jun 23 2021 - 05:44:10 EST


On Tue, Jun 22, 2021 at 01:15:36PM +0100, Matthew Wilcox (Oracle) wrote:
> Transform clear_page_dirty_for_io() into folio_clear_dirty_for_io()
> and add a compatibility wrapper. Also move the declaration to pagemap.h
> as this is page cache functionality that doesn't need to be used by the
> rest of the kernel.
>
> Increases the size of the kernel by 79 bytes. While we remove a few
> calls to compound_head(), we add a call to folio_nr_pages() to get the
> stats correct.

... for the eventual support of multi-page folios.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>