Re: [PATCH v3 0/6] block: add a sequence number to disks

From: Hannes Reinecke
Date: Wed Jun 23 2021 - 08:03:32 EST


On 6/23/21 12:58 PM, Matteo Croce wrote:
From: Matteo Croce <mcroce@xxxxxxxxxxxxx>

With this series a monotonically increasing number is added to disks,
precisely in the genhd struct, and it's exported in sysfs and uevent.

This helps the userspace correlate events for devices that reuse the
same device, like loop.

I'm failing to see the point here.
Apparently you are assuming that there is a userspace tool tracking events, and has a need to correlate events related to different instances of the disk.
But if you have an userspace application tracking events, why can't the same application track the 'add' and 'remove' events to track the lifetime of the devices, and implement its own numbering based on that?

Why do we need to burden the kernel with this?

Cheers,

Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer