Re: [PATCH v4 09/10] scsi: ufs: Update the fast abort path in ufshcd_abort() for PM requests

From: Bart Van Assche
Date: Wed Jun 23 2021 - 17:34:00 EST


On 6/23/21 12:35 AM, Can Guo wrote:
> @@ -2737,7 +2737,7 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
> * err handler blocked for too long. So, just fail the scsi cmd
> * sent from PM ops, err handler can recover PM error anyways.
> */
> - if (hba->wlu_pm_op_in_progress) {
> + if (cmd->request->rq_flags & RQF_PM) {
> hba->force_reset = true;
> set_host_byte(cmd, DID_BAD_TARGET);
> cmd->scsi_done(cmd);

I'm still concerned that the above code may trigger data corruption. I
prefer that the above code is removed instead of being modified.

Thanks,

Bart.