Re: [PATCH v2 -next] crypto: sl3516 - Fix build warning without CONFIG_PM

From: Herbert Xu
Date: Thu Jun 24 2021 - 03:37:06 EST


On Fri, Jun 18, 2021 at 05:35:51PM +0800, YueHaibing wrote:
> drivers/crypto/gemini/sl3516-ce-core.c:345:12:
> warning: ‘sl3516_ce_pm_resume’ defined but not used [-Wunused-function]
> static int sl3516_ce_pm_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
>
> The driver needs PM, otherwise clock and resets are never set.
> So make it depends on PM to fix this warning.
>
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> Suggested-by: LABBE Corentin <clabbe@xxxxxxxxxxxx>
> ---
> v2: Using depends on PM instead of #ifdef macro
>
> drivers/crypto/Kconfig | 1 +
> 1 file changed, 1 insertion(+)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt