Re: [PATCH 09/14] d_path: introduce struct prepend_buffer

From: Enrico Weigelt, metux IT consult
Date: Thu Jun 24 2021 - 05:31:38 EST


Hi folks,

<snip>

>> We've a lot of places where we have pairs of form (pointer to end
>> of buffer, amount of space left in front of that). These sit in pairs of
>> variables located next to each other and usually passed by reference.
>> Turn those into instances of new type (struct prepend_buffer) and pass
>> reference to the pair instead of pairs of references to its fields.
>>
>> Declared and initialized by DECLARE_BUFFER(name, buf, buflen).
>>
>> extract_string(prepend_buffer) returns the buffer contents if
>> no overflow has happened, ERR_PTR(ENAMETOOLONG) otherwise.
>> All places where we used to have that boilerplate converted to use
>> of that helper.

this smells like a generic enough thing to go into lib, doesn't it ?


--mtx

--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287