Re: [PATCH 2/6] KVM: mmu: also return page from gfn_to_pfn
From: Paolo Bonzini
Date: Thu Jun 24 2021 - 05:42:46 EST
On 24/06/21 10:52, Nicholas Piggin wrote:
For now, wrap all calls to gfn_to_pfn functions in the new helper
Hmm. You mean callers that do need the page will be updated? Normally
function. Callers which don't need the page struct will be updated in
if there will be leftover users that don't need the struct page then
you would go the other way and keep the old call the same, and add a new
one (gfn_to_pfn_page) just for those that need it.
Needing kvm_pfn_page_unwrap is a sign that something might be buggy, so
it's a good idea to move the short name to the common case and the ugly
kvm_pfn_page_unwrap(gfn_to_pfn(...)) for the weird one. In fact I'm not
sure there should be any kvm_pfn_page_unwrap in the end.