Re: [PATCH v2 2/4] lib/vsprintf.c: make '%pD' print the full path of file
From: Andy Shevchenko
Date: Thu Jun 24 2021 - 06:49:51 EST
On Thu, Jun 24, 2021 at 11:01:31AM +0200, Petr Mladek wrote:
> On Wed 2021-06-23 13:50:09, Jia He wrote:
> > If someone invokes snprintf() with small but positive space,
> > prepend_name_with_len() moves or truncates the string partially.
> Does this comment belong to the 1st patch?
> prepend_name_with_len() is not called in this patch.
> > More
> > than that, kasprintf() will pass NULL @buf and @end as the parameters,
> > and @end - @buf can be negative in some case. Hence make it return at
> > the very beginning with false in these cases.
> Same here. file_d_path_name() does not return bool.
It was my (apparently unclear) suggestion either to move it here, or be
rewritten in generic way as you suggested in the other thread.
With Best Regards,