Re: [PATCH 2/7] perf: Create a symlink for a PMU

From: Andi Kleen
Date: Thu Jun 24 2021 - 13:49:46 EST



That is not how sysfs and the driver model works, sorry. You don't get
to keep both names, otherwise sysfs would be even more of a mess than it
currently is. What happens if you need "another" name in the future?
When do you stop

I don't see any scenario where we would ever need more than a single symlink.

I believe there is already precedent for this elsewhere.


this isn't ok, please do it right.

I don't see what exactly are you proposing.

Are you proposing to break every perf script on a kernel update? Doesn't seem acceptable to me.

Or move the compatibility into the perf tool? That would require the users to both update the perf tool and the kernel. I suppose it would be possible, but it would be totally against the standard perf abstraction design. Besides there are other consumers of this than just the perf tool, so it could possibly have a wide impact.

-Andi