Re: [PATCH] seq_buf: let seq_buf_putmem_hex support len larger than 8

From: Steven Rostedt
Date: Fri Jun 25 2021 - 09:27:42 EST


On Fri, 25 Jun 2021 15:28:25 +0800
Yun Zhou <yun.zhou@xxxxxxxxxxxxx> wrote:

> Hi Mr Steven,
>
> I found that you had ever wanted to enhance trace_seq_putmem_hex() to
>
> allow any size input(6d2289f3faa71dcc). Great minds think alike. Your
>
> enhancement will let the function more robust, I think it is very advisable.
>
> Now we only need modify two lines to solve a little flaw, and to let it
>
> more more robust.

You are still solving two bugs with one patch, which is considered a no-no.

One bug fix needs to go back to the beginning. If you want to add the
other update, then it could be labeled a fix to that commit. Either
way, it requires two patches.

-- Steve