RE: [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime
From: Min Li
Date: Fri Jun 25 2021 - 10:24:31 EST
How would you suggest to implement the change that make the new driver behavior optional?
There is no additional parameter in adjtime to let me do that.
> -----Original Message-----
> From: Richard Cochran <richardcochran@xxxxxxxxx>
> Sent: June 24, 2021 12:20 PM
> To: Min Li <min.li.xe@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime
> On Thu, Jun 24, 2021 at 02:38:46PM +0000, Min Li wrote:
> > I have tested this change with ptp4l for by setting step_window to 48
> > (assuming 16 packets per second) for both 8265.2/8275.1 and they
> performed well.
> Both of these patches assume that user space has a special configuration
> that works together with the non-standard driver behavior.
> For this reason, I suggest making the new driver behavior optional, with the
> default being the origin version that "just works". In that way, the
> admin/user can choose the special configuration on purpose, and the
> default performance will not be degraded.