Re: usb: host: Reduce xhci_handshake timeout in xhci_reset

From: Greg Kroah-Hartman
Date: Mon Jun 28 2021 - 02:53:15 EST


On Mon, Jun 28, 2021 at 11:25:48AM +0900, Jung Daehwan wrote:
> On Tue, Jun 22, 2021 at 09:56:20PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 22, 2021 at 08:24:56PM +0900, Daehwan Jung wrote:
> > > It seems 10 secs timeout is too long in general case. A core would wait for
> > > 10 secs without doing other task and it can be happended on every device.
> >
> > Only if the handshake does not come back sooner, right?
>
> Yes, right.
>
> > What is causing your device to timeout here?
>
> Host Controller doesn't respond handshake. I don't know why and I ask HW team
> to debug it.

Please work to fix your hardware, that feels like the root of the
problem here. If you require the timeout for xhci_reset() to happen,
then how do you know that the hardware really did reset properly in the
reduced amount of time you just provided?

thanks,

greg k-h