Re: [PATCH v7 00/20] Introduce threaded trace streaming for basic perf record operation

From: Bayduraev, Alexey V
Date: Mon Jun 28 2021 - 04:11:52 EST


Hello,

On 27.06.2021 3:46, Namhyung Kim wrote:
> Hello,
>
> On Tue, Jun 22, 2021 at 1:42 AM Alexey Bayduraev
> <alexey.v.bayduraev@xxxxxxxxxxxxxxx> wrote:
>>
>> Changes in v7:
>> - fixed possible crash after out_free_threads label
>> - added missing pthread_attr_destroy() call
>> - added check of correctness of user masks
>> - fixed zsts_data finalization
>>
[SNIP]
> Thanks for your work, mostly looks good now.
>
> I have a question, where are the synthesized records saved?
> Is it the data.0 file?

Thanks for the review.

As I understand the synthesized records (as well as other user-space
records) are saved to perf.data/data, kernel records are saved to
perf.data/data.<CPU>

Regards,
Alexey

>
> Thanks,
> Namhyung
>
>
>>
>> tools/include/linux/bitmap.h | 11 +
>> tools/lib/api/fd/array.c | 17 +
>> tools/lib/api/fd/array.h | 1 +
>> tools/lib/bitmap.c | 14 +
>> tools/perf/Documentation/perf-record.txt | 30 +
>> tools/perf/builtin-inject.c | 3 +-
>> tools/perf/builtin-record.c | 1094 ++++++++++++++++++++--
>> tools/perf/util/evlist.c | 16 +
>> tools/perf/util/evlist.h | 1 +
>> tools/perf/util/mmap.c | 6 +
>> tools/perf/util/mmap.h | 6 +
>> tools/perf/util/ordered-events.h | 1 +
>> tools/perf/util/record.h | 2 +
>> tools/perf/util/session.c | 500 +++++++---
>> tools/perf/util/session.h | 5 +
>> tools/perf/util/tool.h | 3 +-
>> 16 files changed, 1508 insertions(+), 202 deletions(-)
>>
>> --
>> 2.19.0
>>