Re: [PATCH] gfs2: Fix error handling in init_statfs()

From: Andreas Gruenbacher
Date: Mon Jun 28 2021 - 08:24:03 EST


Hi Jing,

On Mon, Jun 28, 2021 at 1:22 PM Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx> wrote:
> In an error path of init_statfs(), it calls iput to put pn which has been
> put. Jump to correct label to fix it.

thanks for your patch. This looks okay, but I'd rather set pn to NULL
after the iput instead. Since iput(NULL) is a no-op, we'll end up with
the same result.

Andreas