Re: [PATCH] staging: rtl8723bs: Fix a resource leak in sd_int_dpc

[Hans de Goede]

Hi,

On 6/28/21 5:22 PM, Xiangyang Zhang wrote:
> The "c2h_evt" variable is not freed when function call
> "c2h_evt_read_88xx" failed
> 
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Signed-off-by: Xiangyang Zhang <xyz.sun.ok@xxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans



> ---
>  drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index 2dd251ce177e..a545832a468e 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -909,6 +909,8 @@ void sd_int_dpc(struct adapter *adapter)
>  				} else {
>  					rtw_c2h_wk_cmd(adapter, (u8 *)c2h_evt);
>  				}
> +			} else {
> +				kfree(c2h_evt);
>  			}
>  		} else {
>  			/* Error handling for malloc fail */
>