Re: [Patch v2 2/3] Drivers: hv: add Azure Blob driver

From: Enrico Weigelt, metux IT consult
Date: Tue Jun 29 2021 - 06:42:27 EST

On 29.06.21 08:24, Greg Kroah-Hartman wrote:

Hi folks,

Again, no.

Just use dev_dbg(), dev_warn(), and dev_err() and there is no need for
anything "special". This is just one tiny driver, do not rewrite logic
like this for no reason.

Maybe worth mentioning that we have the pr_fmt macro that can be
defined if some wants to do things like adding some prefix.

No need to ever check any debugfs calls, please just make them and move

In this case a failed attempt to create debugfs files/dirs should not be
treated as some actual error, but a normal situation, therefore there
shouldn't be an error message. (see debugfs.h)


Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287