Re: [PATCH] regulator: palmas: set supply_name after registering the regulator
From: Mark Brown
Date: Tue Jun 29 2021 - 11:59:54 EST
On Tue, Jun 29, 2021 at 05:24:03PM +0200, H. Nikolaus Schaller wrote:
> Commit 98e48cd9283d ("regulator: core: resolve supply for boot-on/always-on regulators")
> introduced a new rule which makes Palmas regulator registration fail:
> [ 5.407712] ldo1: supplied by vsys_cobra
> [ 5.412748] ldo2: supplied by vsys_cobra
> [ 5.417603] palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmas@48:palmas_pmic regulator
> This seems to block additions initializations and finally the
> Pyra-Handheld hangs when trying to access MMC because there is
> no mmc-supply available.
What is that rule and how is this patch intended to ensure that Palmas
meets it? As covered in submitting-patches.rst your changelog should
explain this so that in review we can verify that this is a good fix.
The change itself looks worrying like it just shuts the error up and
could cause problems for other systems.
Description: PGP signature