Re: [PATCH 1/2] objtool: Check for gelf_update_rel[a] failures

From: Josh Poimboeuf
Date: Tue Jun 29 2021 - 13:12:48 EST


On Mon, Jun 28, 2021 at 10:24:38AM +0200, Peter Zijlstra wrote:
> On Mon, Jun 28, 2021 at 12:52:07AM -0700, Michael Forney wrote:
> > On 2021-05-08, Michael Forney <mforney@xxxxxxxxxxx> wrote:
> > > Otherwise, if these fail we end up with garbage data in the
> > > .rela.orc_unwind_ip section, leading to errors like
> > >
> > > ld: fs/squashfs/namei.o: bad reloc symbol index (0x7f16 >= 0x12) for
> > > offset 0x7f16d5c82cc8 in section `.orc_unwind_ip'
> > >
> > > Signed-off-by: Michael Forney <mforney@xxxxxxxxxxx>
> >
> > Ping on these patches.
>
> Josh, I forever forget which libelf versions we're supposed to support,
>
> But these patches do look reasonable to me, wdyt?

Looks ok to me. Let me run them through some testing.

--
Josh