Re: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks

From: 陈华才
Date: Thu Jul 01 2021 - 21:15:53 EST

Hi, Bjorn,

> -----原始邮件-----
&gt; 发件人: "Bjorn Helgaas" <helgaas@xxxxxxxxxx>
&gt; 发送时间: 2021-07-01 23:46:34 (星期四)
&gt; 收件人: "Artem Lapkin" <email2tema@xxxxxxxxx>
&gt; 抄送: narmstrong@xxxxxxxxxxxx,, khilman@xxxxxxxxxxxx, lorenzo.pieralisi@xxxxxxx, robh@xxxxxxxxxx, kw@xxxxxxxxx, jbrunet@xxxxxxxxxxxx, christianshewitt@xxxxxxxxx, martin.blumenstingl@xxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, art@xxxxxxxxxx, nick@xxxxxxxxxx, gouwa@xxxxxxxxxx, "Huacai Chen" <chenhuacai@xxxxxxxxxxx>
&gt; 主题: Re: [PATCH 0/4] PCI: replace dublicated MRRS limit quirks
&gt; [+cc Huacai]
&gt; On Sat, Jun 19, 2021 at 02:39:48PM +0800, Artem Lapkin wrote:
&gt; &gt; Replace dublicated MRRS limit quirks by mrrs_limit_quirk from core
&gt; &gt; * drivers/pci/controller/dwc/pci-keystone.c
&gt; &gt; * drivers/pci/controller/pci-loongson.c
&gt; s/dublicated/duplicated/ (several occurrences)
&gt; Capitalize subject lines.
&gt; Use "git log --online" to learn conventions and follow them.
&gt; Add "()" after function names.
&gt; Capitalize acronyms appropriately (NVMe, MRRS, PCI, etc).
&gt; End sentences with periods.
&gt; A "move" patch must include both the removal and the addition and make
&gt; no changes to the code itself.
&gt; Amlogic appears without explanation in 2/4. Must be separate patch to
&gt; address only that specific issue. Should reference published erratum
&gt; if possible. "Solves some issue" is not a compelling justification.
&gt; The tree must be consistent and functionally the same or improved
&gt; after every patch.
&gt; Add to pci_ids.h only if symbol used more than one place.
&gt; See
&gt; which looks similar. Combine efforts if possible and cc Huacai so
&gt; you're both aware of overlapping work.
&gt; More hints in case they're useful:
&gt; &gt; Both ks_pcie_quirk loongson_mrrs_quirk was rewritten without any
&gt; &gt; functionality changes by one mrrs_limit_quirk
Does that means keystone and Loongson has the same MRRS problem? And what should I do now?

&gt; &gt;
&gt; &gt; Added DesignWare PCI controller which need same quirk for
&gt; &gt; * drivers/pci/controller/dwc/pci-meson.c (PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3)
&gt; &gt;
&gt; &gt; This quirk can solve some issue for Khadas VIM3/VIM3L(Amlogic)
&gt; &gt; with HDMI scrambled picture and nvme devices at intensive writing...
&gt; &gt;
&gt; &gt; come from:
&gt; &gt; *
&gt; &gt;
&gt; &gt; Artem Lapkin (4):
&gt; &gt; PCI: move Keystone and Loongson device IDs to pci_ids
&gt; &gt; PCI: core: quirks: add mrrs_limit_quirk
&gt; &gt; PCI: keystone move mrrs quirk to core
&gt; &gt; PCI: loongson move mrrs quirk to core
&gt; &gt;
&gt; &gt; --
&gt; &gt; 2.25.1
&gt; &gt;