staging: rtl8712: dead code on flush_signals_thread call in r8712_cmd_thread()

From: Colin Ian King
Date: Fri Jul 02 2021 - 09:04:21 EST


Hi,

Static analysis by Coverity has detected a call to
flush_signals_thread() that is never executed. If it is removed it
won't affect the current behavior, however I'm pretty sure the call was
intentionally placed in the code at the end of a while loop so I believe
there is something a little dubious with the current code.

The analysis by Coverity is as follows:

384 goto _next;
385 }

Structurally dead code (UNREACHABLE)
unreachable: This code cannot be reached: flush_signals_thread();.

386 flush_signals_thread();
387 }

Any ideas?

Colin